Skip to content

[Auth] Fix casting error in Swift 6 #14025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

[Auth] Fix casting error in Swift 6 #14025

merged 1 commit into from
Nov 4, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 4, 2024 •
edited
Loading

Screenshot 2024-11-04 at 4 54 14 PM

Based on some examples I found, it looks like this value should be JSON string. I did a test in playgrounds and it looks like it can be casted to [String:Sendable]

#no-changelog

@ncooke3 ncooke3 requested a review from andrewheard November 4, 2024 21:55
andrewheard
andrewheard approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this should be safe since I'd expect all the JSON-compatible types to be Sendable.

@ncooke3 ncooke3 merged commit 0a49232 into main Nov 4, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/cast-error branch November 4, 2024 22:44
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncooke3 @andrewheard @google-oss-bot